-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make RecoLocalCalo/EcalRecProducers compile with C++20 #42293
Conversation
type bug-fix |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42293/36317
|
A new Pull Request was created by @iarspider for master. It involves the following packages:
@mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-805923/33739/summary.html Comparison SummarySummary:
|
@cms-sw/reconstruction-l2 can you please review this? this is needed for moving forward with c++20 standard |
+reconstruction |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
C++20 made it invalid to use simple-template-ids for constructors and destructors: https://eel.is/c++draft/diff.cpp17.class#2 . GCC 11 and later throw an error on this, with the unhelpful message expected
unqualified-id before ')' token.
This PR fixes the problem.PR validation:
Code compiles